fix(vue-app): avoid multiple $fetch calls (#7129)

Co-authored-by: Aster <duda84@gmail.com>
nuxt · Mar 25, 2020 · 0f27f80 · 0f27f80
1 parent b82f8d1
commit 0f27f80
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/vue-app/template/mixins/fetch.client.js b/packages/vue-app/template/mixins/fetch.client.js
@@ -52,7 +52,15 @@ function created() {
   }
 }
 
-async function $fetch() {
+function $fetch() {
+  if (!this._fetchPromise) {
+    this._fetchPromise = $_fetch.call(this)
+      .then(() => { delete this._fetchPromise })
+  }
+  return this._fetchPromise
+}
+
+async function $_fetch() {
   this.<%= globals.nuxt %>.nbFetching++
   this.$fetchState.pending = true
   this.$fetchState.error = null

diff --git a/packages/vue-app/template/utils.js b/packages/vue-app/template/utils.js
@@ -638,5 +638,7 @@ export function addLifecycleHook(vm, hook, fn) {
   if (!vm.$options[hook]) {
     vm.$options[hook] = []
   }
-  vm.$options[hook].push(fn)
+  if (!vm.$options[hook].includes(fn)) {
+    vm.$options[hook].push(fn)
+  }
 }