Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-timing header is always returned even when turned off #15660

Closed
oritwoen opened this issue Dec 22, 2022 · 2 comments · Fixed by unjs/nitro#823
Closed

server-timing header is always returned even when turned off #15660

oritwoen opened this issue Dec 22, 2022 · 2 comments · Fixed by unjs/nitro#823

Comments

@oritwoen
Copy link
Contributor

Environment


  • Operating System: Linux
  • Node Version: v16.14.2
  • Nuxt Version: 3.0.0
  • Nitro Version: 1.0.0
  • Package Manager: npm@7.17.0
  • Builder: vite
  • User Config: nitro
  • Runtime Modules: -
  • Build Modules: -

Reproduction

Default nuxt deploy from nuxt.new:

Nuxt deploy with nitro -> timing -> false

Response Header:

server-timing : -;dur=0;desc="Generate"

Describe the bug

Regardless of the choice, the timing header is always returned in the response headers. Where such a header should not be returned by default.

Additional context

No response

Logs

No response

@issue-up
Copy link

issue-up bot commented Dec 22, 2022

@clarkdo
Copy link
Member

clarkdo commented Jan 10, 2023

Hi @oritwoen, nitro.timing is for controlling Nitro start/load timing log info instead of server-timing for now, we'll improve the doc and fix the config on the header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants