fix(generator): log message or full error for unhandled error without stack trace #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
approved these changes
Jan 17, 2020
|
Maybe in the future create a common util for this? /cc @pimlie |
|
There is a TODO in the Generator class to use consola for formatting errors. I looked briefly into that but didnt find an easy way to do that |
Merged
This was referenced Mar 20, 2020
This was referenced Mar 28, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6853
Types of changes
Description
As the linked issue doesnt contain a repro, I couldnt fully confirm this fixes it. But looking at the logs this should fix it.
Checklist: