Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tpc): a type annotation is necessary #133

Closed
dargmuesli opened this issue Jul 6, 2024 · 7 comments · Fixed by #141 or #151
Closed

fix(tpc): a type annotation is necessary #133

dargmuesli opened this issue Jul 6, 2024 · 7 comments · Fixed by #141 or #151
Assignees
Labels
bug Something isn't working pre-announce

Comments

@dargmuesli
Copy link
Member

Upgrading to v6.0.2 I get the following errors in the Nuxt Turnstile module:

.nuxt/nuxt-scripts/tpc/google-tag-manager.ts(13,17): error TS2742: The inferred type of 'useScriptGoogleTagManager' cannot be named without a reference to '.pnpm/@unhead+vue@1.9.15_vue@3.4.31_typescript@5.5.3_/node_modules/@unhead/vue'. This is likely not portable. A type annotation is necessary.
.nuxt/nuxt-scripts/tpc/google-tag-manager.ts(6,7): error TS2742: The inferred type of 'OptionSchema' cannot be named without a reference to '.pnpm/valibot@0.36.0/node_modules/valibot'. This is likely not portable. A type annotation is necessary.
.nuxt/nuxt-scripts/tpc/google-tag-manager.ts(6,7): error TS2742: The inferred type of 'OptionSchema' cannot be named without a reference to '.pnpm/valibot@0.36.0/node_modules/valibot'. This is likely not portable. A type annotation is necessary.
.nuxt/nuxt-scripts/tpc/google-analytics.ts(13,17): error TS2742: The inferred type of 'useScriptGoogleAnalytics' cannot be named without a reference to '.pnpm/@unhead+vue@1.9.15_vue@3.4.31_typescript@5.5.3_/node_modules/@unhead/vue'. This is likely not portable. A type annotation is necessary.
.nuxt/nuxt-scripts/tpc/google-analytics.ts(6,7): error TS2742: The inferred type of 'OptionSchema' cannot be named without a reference to '.pnpm/valibot@0.36.0/node_modules/valibot'. This is likely not portable. A type annotation is necessary.
.nuxt/nuxt-scripts/tpc/google-analytics.ts(6,7): error TS2742: The inferred type of 'OptionSchema' cannot be named without a reference to '.pnpm/valibot@0.36.0/node_modules/valibot'. This is likely not portable. A type annotation is necessary.

https://github.com/nuxt-modules/turnstile/actions/runs/9820960416/job/27116095724?pr=321#step:14:24

@harlan-zw
Copy link
Collaborator

cc: @huang-julien

@dargmuesli
Copy link
Member Author

@harlan-zw could a release be created for the recently merged changes? ❤️

@harlan-zw
Copy link
Collaborator

@harlan-zw could a release be created for the recently merged changes? ❤️

Sure, just pushed up 0.6.3.

@dargmuesli
Copy link
Member Author

Thank you!
I just noticed that this issue is in fact not fixed yet: https://github.com/nuxt-modules/turnstile/actions/runs/9889245418/job/27314864264?pr=321#step:14:24
Can we reopen?

@harlan-zw harlan-zw reopened this Jul 11, 2024
@huang-julien
Copy link
Member

weird, i tested the fix locally yesterday. Anyway i'll investigate this issue tonight

@harlan-zw
Copy link
Collaborator

Hi, please use 0.6.4

@dargmuesli
Copy link
Member Author

LGTM! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pre-announce
Projects
None yet
3 participants