Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPC script runtime config extending is broken #147

Closed
harlan-zw opened this issue Jul 13, 2024 · 0 comments · Fixed by #153
Closed

TPC script runtime config extending is broken #147

harlan-zw opened this issue Jul 13, 2024 · 0 comments · Fixed by #153
Labels
bug Something isn't working pre-announce

Comments

@harlan-zw
Copy link
Collaborator

harlan-zw commented Jul 13, 2024

Since we're using custom keys for TPC users won't be able to provide config as per the docs and all other scripts.

For example, the NUXT_PUBLIC_SCRIPTS_GOOGLE_TAG_MANAGER_ID key should just work. It doesn't because the key is set to gtm

export default defineNuxtConfig({
  runtimeConfig: {
    public: {
      scripts: {
        googleTagManager: {
          id: '', // NUXT_PUBLIC_SCRIPTS_GOOGLE_TAG_MANAGER_ID
        },
      },
    },
  },
})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pre-announce
Projects
None yet
1 participant