-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Release Tasks #30
Comments
From my own observation, it makes sense to add e2e tests for Registry Scripts to the list. Especially when it comes to analytics, they like to "go crazy". I tried to run Google Analytics and use events but it didn't work at all, hence my suggestion to add tests to the registry as well. Maybe I was doing something wrong in general (I was using the documentation). Anyway, this is a suggestion and if I still have a problem with it after updating the packages, I will make an issue and reproduce it. |
Thank you for the feedback @oritwoen. Unfortunately to do an e2e test with the registry scripts is not fully possible for all scripts, we can support it for registry scripts that expose an API to check the data we send it. I've setup a Google Analytics Reproduction and it seems to be working correctly. If you can provide the code you had an issue with or a reproduction it would help. Also please make a new issue, I'm going to close this one 🙏 |
These are several items that should be completed for the public release of the module. Any contributions are more than welcome.
Tasks for the public announcement: #47
Nuxt
useScript
to Nuxt core (docs: add third parties + scripts documentation nuxt#26854 & feat(nuxt): prompt to installnuxt/scripts
on usage nuxt#27010 (comment))Benchamarks
Documentation
Content
(some content exists on all these pages it just needs polishing)
Getting started
Guides
API
Registry
(see below)
Read Me
Home Page
Nuxt Scripts
Tests
Consuming module
e2e Trigger tests
Registry Scripts
The initial implementation for all of these scripts is complete. No new scripts should be added at this stage.
The below require proper documentation and sanity checks on implementation. There is some tree-shaking improvements to be made, see Cloudflare Web Analytics example as it's complete.
We also need to properly document which scripts can be bundled.
Analytics
Content
Marketing
Payments
Tracking
Util
npm
The text was updated successfully, but these errors were encountered: