Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable auto consent and add nuxt telemetry consent #35

Merged
merged 8 commits into from
Nov 25, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 25, 2020

Background: For sending telemetry events, we once consent users about sending events or not but since it wasn't possible to make a prompt and await on stdin in production and CI/CD environments, it was enabled by default on headless envs. (alternative was forcing on each project creation but at early days it was reported to be annoying even with a notice how to enable in CI)

With this change, we never send any events unless it is explicitly enabled per-machine or per-project.

Also a new cli command nuxt telemetry consent [-g] [dir] introduced so with a post creation hook in create-nuxt-app, we still have chance to opt in users but before first run.

Also I added consent field to events context so if later-on we change events policy, have a way to distinguish events. (clarify: currently if a policy change happens, we shall bump version to force prompt users again before sending events.)

Rolling-out strategy:

  • All events with production env or ci: true tag will be wiped out from database to maximize privacy
  • Older versions of @nuxt/telemetry npm package will be deprecated with a message to notify about implicit behavior and they should upgrade version
  • New version is released as a semver-minor so essentially any new nuxt project will receive update without need to release another version of nuxt

closes #34

@pi0 pi0 changed the title feat: nuxt telemetry consent and feat: disable auto consent and nuxt telemetry consent Nov 25, 2020
@pi0 pi0 requested review from alexchopin, atinux and clarkdo November 25, 2020 10:24
@pi0 pi0 changed the title feat: disable auto consent and nuxt telemetry consent feat: disable auto consent and add nuxt telemetry consent Nov 25, 2020
src/consent.ts Show resolved Hide resolved
@pi0 pi0 merged commit f1a5d95 into master Nov 25, 2020
@pi0 pi0 deleted the fix/opt-in-only branch November 25, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consent disabled on ci/production
4 participants