Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popover): open and close events #1038

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

connerblanton
Copy link
Contributor

πŸ”— Linked issue

#1037

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Emitting open and close events on the Popover component. This will allow users to run additional logic based on the state of the Popover

Resolves #1037

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Nov 30, 2023 3:14pm

@timb-103
Copy link
Sponsor

Wow, that was fast. Thanks Connor!

@benjamincanac benjamincanac changed the title feat(Popover) open and close events feat(Popover): open and close events Dec 11, 2023
@benjamincanac benjamincanac merged commit f32f578 into nuxt:dev Dec 11, 2023
2 checks passed
@benjamincanac
Copy link
Member

@connerblanton FYI I've removed the open and close events in this commit: 3334e2a.

The Popover now supports a v-model:open so users can now listen on update:open to get the state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open & close event for UPopover
3 participants