feat(Modal/Slideover): emit close-prevented event
#1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Youhan
changed the title
|
It would be nice to replicate those changes on the |
|
Oh! right! I'll add it to Sliderover too. Thanks! |
benjamincanac
approved these changes
Jan 19, 2024
benjamincanac
changed the title
close-prevented event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No linked issue
❓ Type of change
📚 Description
The Modal has a
prevent-closeprop. I added an emit for when the close is prevented. This way the user can know that the close is prevented. This is useful when you are preventing a close with a computed ref and you want to do something in the UI when the close is being prevented to prevent rage clicks.📝 Checklist