feat(Table): add checkbox ui config
#1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…77f1 (#1405) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
| @@ -4,7 +4,7 @@ | |||
| <thead :class="ui.thead"> | |||
| <tr :class="ui.tr.base"> | |||
| <th v-if="modelValue" scope="col" :class="ui.checkbox.padding"> | |||
| <UCheckbox :model-value="indeterminate || selected.length === rows.length" :indeterminate="indeterminate" aria-label="Select all" @change="onChange" /> | |||
| <UCheckbox :model-value="indeterminate || selected.length === rows.length" :indeterminate="indeterminate" :color="ui.default.checkbox.color" aria-label="Select all" @change="onChange" /> | |||
There was a problem hiding this comment.
I think it could be nice to v-bind="ui.default.checkbox" here so we can change other props than color.
There was a problem hiding this comment.
This reminds me of this PR: #1269
|
Hi guys, don't know if it is the right place to talk about this sorry if not. Wouldn't it be more flexible to allow selected row slot customization directly? |
|
Thanks @zoobzio and sorry for the delay 😅 |
|
@zguig52 Would you mind opening a new issue for this? An issue might already exists about this topic. |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #1344
❓ Type of change
📚 Description
Add a
checkboxsection to the table config to allow the user to define the color used on the checkbox component used internally by the table component for row selections.📝 Checklist