-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): add checkbox
ui config
#1409
feat(Table): add checkbox
ui config
#1409
Conversation
β¦77f1 (#1405) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@@ -4,7 +4,7 @@ | |||
<thead :class="ui.thead"> | |||
<tr :class="ui.tr.base"> | |||
<th v-if="modelValue" scope="col" :class="ui.checkbox.padding"> | |||
<UCheckbox :model-value="indeterminate || selected.length === rows.length" :indeterminate="indeterminate" aria-label="Select all" @change="onChange" /> | |||
<UCheckbox :model-value="indeterminate || selected.length === rows.length" :indeterminate="indeterminate" :color="ui.default.checkbox.color" aria-label="Select all" @change="onChange" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be nice to v-bind="ui.default.checkbox"
here so we can change other props than color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reminds me of this PR: #1269
Hi guys, don't know if it is the right place to talk about this sorry if not. Wouldn't it be more flexible to allow selected row slot customization directly? |
Thanks @zoobzio and sorry for the delay π |
@zguig52 Would you mind opening a new issue for this? An issue might already exists about this topic. |
π Linked issue
Resolves #1344
β Type of change
π Description
Add a
checkbox
section to the table config to allow the user to define the color used on the checkbox component used internally by the table component for row selections.π Checklist