feat(Link): add as prop
#535
Conversation
|
|
✅ Live Preview ready!
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <component | ||
| :is="as" | ||
| v-if="!to" | ||
| :type="type" |
There was a problem hiding this comment.
Is the type prop here used for specifying the button type? If so, what about v-bind?
There was a problem hiding this comment.
Do you mean v-bind="$attrs"?
There was a problem hiding this comment.
Maybe we should remove both type and disabled prop indeed, not sure to remember why I'd put them here in a first place. Will try to experiment!
There was a problem hiding this comment.
Maybe we should remove both
typeanddisabledprop indeed, not sure to remember why I'd put them here in a first place. Will try to experiment!
I remove type because it's unneeded; we can use v-bind, but disabled has logic in Link
Haythamasalama
force-pushed
the
feat/link-add-as-prop
branch
from
3683de5
to
a68b073
Compare
|
@benjamincanac Can we review this before the big conflicts come crashing in? 😂 |
Added
asprop for customize defaults to rendering when<a>andtonot provided.