-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Link): add as
prop
#535
feat(Link): add as
prop
#535
Conversation
|
✅ Live Preview ready!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
<component | ||
:is="as" | ||
v-if="!to" | ||
:type="type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the type
prop here used for specifying the button type? If so, what about v-bind
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean v-bind="$attrs"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove both type
and disabled
prop indeed, not sure to remember why I'd put them here in a first place. Will try to experiment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove both
type
anddisabled
prop indeed, not sure to remember why I'd put them here in a first place. Will try to experiment!
I remove type
because it's unneeded; we can use v-bind
, but disabled
has logic in Link
3683de5
to
a68b073
Compare
@benjamincanac Can we review this before the big conflicts come crashing in? 😂 |
Added
as
prop for customize defaults to rendering when<a>
andto
not provided.