-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tabs): add visible focus indicator on active tabs #690
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've tried this already but unfortunately, the |
So should I close this then? |
Not sure, is there no way to achieve this without having the |
Maybe this is caused by another piece of css in the component? Because the Tailwind docs state that |
After messing around, I found out that the outline only appears after you have moving around using Tab key. |
If you go the preview url, scroll down a bit and click on the tabs, the focus appears without having pressed any key. |
This issue in Headless UI looks relevant: tailwindlabs/headlessui#1694 Basically a manual |
This should be working now. The tradeoff is that there's one more package for users when they install the module. |
I don't mind adding this plugin. Maybe the focus should be on all the tabs instead of only the selected one? |
Initialy, I tried that. But when I focus on an inactived tab using keyboard and press Enter, nothing change. |
I think showing the focus ring on the selected tab is the correct behaviour - it's the tab itself that has focus rather than the tablist, and it reflects the behaviour of the WAI tabs example |
Sorry but #692 introduced quite a few changes, would you mind fixing the conflicts? |
…nd there was no time to fix it properly. permalink: http://whatthecommit.com/de3a706f3336bd6b3c70fda43753f859
I messed up pretty hard but it should be okay now. |
Closes #685.