-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RadioGroup): new component #730
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@benjamincanac it's ready to go. I'm tempted to merge the Radio and RadioGroup documentation in the docs (does not really make sense to use a Radio on it's own IMO), I kept both for now to make it easier to review. |
Thanks for picking this up @romhml! It's looking great so far Would it be possible to add a |
Thanks @matteason! I added a prop / slot to include a legend, wdyt? |
@romhml Perfect, thank you! |
It could make sense to merge both indeed. I'm just unsure about the |
@benjamincanac that's what it's called in every popular libraries I've seen and the MDN Web docs so I'd rather stick with that. We can always alias the import from headless-ui if we want to use it don't you think? This is already the case for the select menu. |
Okay let's do this! Do you plan to merge both |
@benjamincanac Done! |
Thanks @romhml, I've made a few changes if you want to take a look! |
I'm merging this, if you see anything that I missed let me know, we'll open a new PR π |
π Linked issue
Fixes #684
β Type of change
Introducing a new component
RadioGroup
to simplify the use of Radio's in forms and fix accessibility issues.π Description
π Checklist