-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module): retain props reactivity through useUI
#745
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Awesome! Why did you mark this as breaking change? |
Because I encountered an error when trying to run |
Oh yes indeed, I'll update |
useUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering, since you defined class
as string
, this prevents the use of arrays and objects. Does this mean we have to implement what Vue does by default?
https://vuejs.org/guide/essentials/class-and-style.html#binding-html-classes
I tested assigning objects and arrays to the class prop, and it transformed them into strings automatically. |
Ok, so we just need to fix the types right? |
What type should we fix? |
I see, I didn't encounter a type error when I tested it in the playground. Maybe my VS Code has an issue. Yes, we should update |
I guess we can define the class: {
type: [String, Object, Array] as PropType<string | Record<string, unknown> | Array<string>>,
default: undefined
} |
I just updated the |
Looks good! I'll finish the update of |
@aditio-eka Just made this so we can pass the config as a Should we update the |
I guess we can update the |
Thanks for the PR! π |
π Linked issue
#742
β Type of change
π Description
Resolves #742. There are two main changes:
class
instead of the fallthrough attribute because the fallthrough attribute isn't reactive.Read more
toRef
to retain reactivityRead more
π Checklist