Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Accordion): toggle correct element when keyboard press #805

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fix(Accordion): toggle correct element when keyboard press #805

merged 3 commits into from
Oct 12, 2023

Conversation

Sma11X
Copy link
Contributor

@Sma11X Sma11X commented Oct 11, 2023 •
edited
Loading

🔗 Linked issue

resolve #626

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fix the wrong toggle element when using keyboard with Accordion component.

But I'm not sure this might be the best solution because if headlessui change that component one day in the future, this issue might happen again.

cc @Haythamasalama

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Oct 11, 2023 9:35am

Haythamasalama
Haythamasalama approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Haythamasalama Haythamasalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works well 👍

@benjamincanac benjamincanac merged commit 96296c3 into nuxt:dev Oct 12, 2023
2 checks passed
@benjamincanac
Copy link
Member

Thanks 😊

@Sma11X Sma11X deleted the fix/accordion-keyboard-press branch October 12, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

@Haythamasalama Haythamasalama Haythamasalama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyboard focus jumps when opening accordion section
3 participants
@Sma11X @benjamincanac @Haythamasalama