feat(Tooltip): adding option to show popper arrow

[connerblanton]

🔗 Linked issue

#836

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added the option to include an arrow on the popper instance for the Tooltip component. It's optional, so no breaking changes.

Popper object prop doesn't have any documentation so I added a few examples on the Tooltip page.

Resolves #836

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	Oct 26, 2023 1:40pm

[benjamincanac]

Just tried the preview and there is a weird transition on the arrow coming from the left.

[connerblanton]

@benjamincanac Good catch! I guess it was too late last night for my eyes to notice that 😅 Latest preview has that fixed now

[benjamincanac]

Awesome, thank you! 😊 We should do the same examples for other components using popper too!

[connerblanton]

I can do that! Do we want to add the arrow option to those other components too? Not sure it makes as much for those as the Tooltip, but maybe someone will eventually want it. Also shouldn't cause any issues since it's optional.

Let me know what you think. Regardless, I can at least update the documentation for the others

[benjamincanac]

Oh this would be awesome! I'm not sure, does a Dropdown, SelectMenu, ContextMenu or Popover would ever have an arrow?

[connerblanton]

That's my thought that as well. I don't know if I would ever use it, but maybe someone at some point will?

It is now an available option in popper.d.ts, so maybe it should be added? To get it working in those components, we would have to add this line to those components and then make some changes in the ui.config.ts file to have it use the same classes.

It would definitely be a "nice-to-have" feature, but it's also not much work since the main logic for it already exists

[benjamincanac]

Yeah I guess we can add it to all the components for consistency.

[connerblanton]

Cool! I'll create a new issue and get started on that. Feel free to assign it to me

[benjamincanac]

Thanks a lot 😊