-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tooltip): adding option to show popper arrow #868
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Just tried the preview and there is a weird transition on the arrow coming from the left. |
@benjamincanac Good catch! I guess it was too late last night for my eyes to notice that π Latest preview has that fixed now |
Awesome, thank you! π We should do the same examples for other components using popper too! |
I can do that! Do we want to add the Let me know what you think. Regardless, I can at least update the documentation for the others |
Oh this would be awesome! I'm not sure, does a |
That's my thought that as well. I don't know if I would ever use it, but maybe someone at some point will? It is now an available option in popper.d.ts, so maybe it should be added? To get it working in those components, we would have to add this line to those components and then make some changes in the It would definitely be a "nice-to-have" feature, but it's also not much work since the main logic for it already exists |
Yeah I guess we can add it to all the components for consistency. |
Cool! I'll create a new issue and get started on that. Feel free to assign it to me |
Thanks a lot π |
π Linked issue
#836
β Type of change
π Description
Added the option to include an arrow on the popper instance for the Tooltip component. It's optional, so no breaking changes.
Popper object prop doesn't have any documentation so I added a few examples on the Tooltip page.
Resolves #836
π Checklist