Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Notifications): teleport to body #909

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix(Notifications): teleport to body #909

merged 1 commit into from
Nov 3, 2023

Conversation

arashsheyda
Copy link
Member

@arashsheyda arashsheyda commented Nov 2, 2023 •
edited by benjamincanac
Loading

🔗 Linked issue

Fixes #904

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Notifications cant be clicked when another overlay is open(e.g. slideover). using Teleport allow user to click on notifiaction.

without teleport
Screen.Recording.2023-11-02.at.4.49.11.PM.mov
with teleport
Screen.Recording.2023-11-02.at.4.55.29.PM.mov

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Nov 2, 2023 11:15pm

@benjamincanac benjamincanac changed the title fix(Notifications): add teleport fix(Notifications): teleport to body Nov 3, 2023
@benjamincanac
Copy link
Member

Thanks! 😊

@benjamincanac benjamincanac merged commit 8451f4d into nuxt:dev Nov 3, 2023
2 checks passed
@arashsheyda arashsheyda deleted the fix/notifications branch November 3, 2023 15:55
@benjamincanac benjamincanac mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast is hidden behind modal overlay
2 participants
@arashsheyda @benjamincanac