fix: handle npm v7 overwriting node_modules symlink
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
force-pushed
the
fix/support-npm-v7
branch
from
5d8a839 to
452b563
Compare
danielroe
force-pushed
the
fix/support-npm-v7
branch
from
ec7a60b to
67d998a
Compare
pi0
reviewed
Nov 23, 2022
| const stats = await fs.stat(modulesPath) | ||
| if (stats.isDirectory()) { | ||
| await fs.rm(namespacedPath, { force: true, recursive: true }) | ||
| await fs.move(modulesPath, namespacedPath) |
There was a problem hiding this comment.
Perf: Can we make these two in parallel?
There was a problem hiding this comment.
I don't think so - we need to remove the directory before moving a new directory into its place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #633
The issue was that npm v7 (enabled in
@vercel/build-utilsv2.12.0 by vercel/vercel#6532) apparently refuses to install into a symlinkednode_modulesfolder so dev dependencies were being added to the lambda.This PR re-upgrades to the latest build-utils and adds a workaround for this npm behaviour.