From 173b31d1d79e4dcd1f47421bf49101ca286f030c Mon Sep 17 00:00:00 2001 From: pimlie Date: Tue, 5 Mar 2019 14:17:28 +0100 Subject: [PATCH] feat: export hasMetaInfo helper function --- examples/basic/app.js | 2 +- src/browser.js | 14 ++++++++------ src/index.js | 12 +++++++----- test/plugin-server.test.js | 4 ++-- test/utils/index.js | 3 +-- 5 files changed, 19 insertions(+), 16 deletions(-) diff --git a/examples/basic/app.js b/examples/basic/app.js index d7aa71a5..d56a2745 100644 --- a/examples/basic/app.js +++ b/examples/basic/app.js @@ -1,5 +1,5 @@ import Vue from 'vue' -import VueMeta from 'vue-meta' +import * as VueMeta from 'vue-meta' Vue.use(VueMeta) diff --git a/src/browser.js b/src/browser.js index 8839c059..2567240a 100644 --- a/src/browser.js +++ b/src/browser.js @@ -3,13 +3,13 @@ import createMixin from './shared/mixin' import setOptions from './shared/options' import { isUndefined } from './shared/typeof' import $meta from './client/$meta' -export { hasMetaInfo } from './shared/hasMetaInfo' +import { hasMetaInfo } from './shared/hasMetaInfo' /** * Plugin install function. * @param {Function} Vue - the Vue constructor. */ -function VueMeta(Vue, options = {}) { +function install(Vue, options = {}) { options = setOptions(options) Vue.prototype.$meta = $meta(options) @@ -17,12 +17,14 @@ function VueMeta(Vue, options = {}) { Vue.mixin(createMixin(Vue, options)) } -VueMeta.version = version - // automatic install if (!isUndefined(window) && !isUndefined(window.Vue)) { /* istanbul ignore next */ - Vue.use(VueMeta) + install(window.Vue) } -export default VueMeta +export default { + version, + install, + hasMetaInfo +} diff --git a/src/index.js b/src/index.js index cb378840..5ed7470e 100644 --- a/src/index.js +++ b/src/index.js @@ -2,13 +2,13 @@ import { version } from '../package.json' import createMixin from './shared/mixin' import setOptions from './shared/options' import $meta from './server/$meta' -export { hasMetaInfo } from './shared/hasMetaInfo' +import { hasMetaInfo } from './shared/hasMetaInfo' /** * Plugin install function. * @param {Function} Vue - the Vue constructor. */ -function VueMeta(Vue, options = {}) { +function install(Vue, options = {}) { options = setOptions(options) Vue.prototype.$meta = $meta(options) @@ -16,6 +16,8 @@ function VueMeta(Vue, options = {}) { Vue.mixin(createMixin(Vue, options)) } -VueMeta.version = version - -export default VueMeta +export default { + version, + install, + hasMetaInfo +} diff --git a/test/plugin-server.test.js b/test/plugin-server.test.js index 85c445ca..b989d7d7 100644 --- a/test/plugin-server.test.js +++ b/test/plugin-server.test.js @@ -1,4 +1,4 @@ -import { mount, defaultOptions, hasMetaInfo, VueMetaServerPlugin, loadVueMetaPlugin } from './utils' +import { mount, defaultOptions, VueMetaServerPlugin, loadVueMetaPlugin } from './utils' jest.mock('../package.json', () => ({ version: 'test-version' @@ -64,7 +64,7 @@ describe('plugin', () => { const { vm } = mount(Component, { localVue: Vue }) - expect(hasMetaInfo(vm)).toBe(true) + expect(VueMetaServerPlugin.hasMetaInfo(vm)).toBe(true) expect(warn).not.toHaveBeenCalled() warn.mockRestore() diff --git a/test/utils/index.js b/test/utils/index.js index b4f4fccf..fee4c7b7 100644 --- a/test/utils/index.js +++ b/test/utils/index.js @@ -1,7 +1,7 @@ import { mount, createLocalVue } from '@vue/test-utils' import { renderToString } from '@vue/server-test-utils' import VueMetaBrowserPlugin from '../../src/browser' -import VueMetaServerPlugin, { hasMetaInfo } from '../../src' +import VueMetaServerPlugin from '../../src' import { keyName, @@ -15,7 +15,6 @@ import { export { mount, renderToString, - hasMetaInfo, VueMetaBrowserPlugin, VueMetaServerPlugin }