-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debounceWait is not working as expected in universal mode #468
Comments
The head function is not really the place to change options, better to do that in a created hook or something like that. |
@pimlie strange, as far as I remember, you've been recommending to do this in head() |
But still it shouldnt error out, there seems to be a regression now when you dont return anything in head/metaInfo |
I see...the fact that I used head() without returning anything caused an override of the internal components head() data, right? |
no, the issue is that vue-meta returns early when the result is not an object but that also means child components wont be traversed. Have a fix ready, just trying to add a test for it now |
See linked pr |
@pimlie so it would be safe to set options in head() after this PR? |
Changing options should be done outside of the metaInfo / head function. That is specifically meant for collecting meta info and can be called many times during the lifecycle of a Vue app. |
Version: 2.3.0
How to recreate:
Add
into layouts/default.vue
Result:
All meta info is undefined. Page meta is not updated on router change.
Removing
debounceWait
fixes an issueThe text was updated successfully, but these errors were encountered: