Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak #522

Closed
wants to merge 2 commits into from
Closed

fix memory leak #522

wants to merge 2 commits into from

Conversation

Remcoman
Copy link

fixes #521

@Remcoman Remcoman requested a review from pimlie February 19, 2020 20:45
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #522 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #522     +/-   ##
=========================================
- Coverage   99.25%   98.95%   -0.3%     
=========================================
  Files          33       33             
  Lines         673      673             
  Branches      204      204             
=========================================
- Hits          668      666      -2     
- Misses          3        5      +2     
  Partials        2        2
Impacted Files Coverage Δ
src/shared/mixin.js 94.59% <100%> (ø) ⬆️
src/utils/ensure.js 71.42% <0%> (-28.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b80129...0837b7d. Read the comment docs.

Copy link
Collaborator

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for looking into this. I have debugged this extensively in the past but unfortunately couldnt find the root cause. There indeed seems to be an issue still left but I have been unable to find a vanilla Vue.js reproduction to prove/understand whats really happening. For reference have a look at this issue: vuejs/vue#10458

If you have time, maybe you could try to create a vanilla Vue.js reproduction of this error?

Again unfortunately, using hook: events is an internal Vue.js API and I was advised at the time by the Vue core team to not use it. Because of that I will be unable to merge this PR for now, sorry.

@pimlie pimlie closed this Feb 23, 2020
pimlie added a commit that referenced this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed: Memory leak
3 participants