feat: add amp-boilerplate as boolean attribute (resolves: #530) #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 33 33
Lines 673 673
Branches 205 205
=======================================
Hits 668 668
Misses 3 3
Partials 2 2
Continue to review full report at Codecov.
|
pimlie
approved these changes
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the AMP specification, documents need to include a style tag with the boolean attribute
amp-boilerplatein the<head>of the page. At the moment, addingamp-boilerplate: trueto a style object inhtmlAttrsoutputs<style amp-boilerplate="true">, which leads to an AMP validation error. For this reason,amp-boilerplateshould be added to thebooleanHtmlAttributes, as it has already been done for the attributeamp.