-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: handle color states on form elements #234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #229, resolves #202
This pull request introduces some breaking changes to provide color states to
Input
,Textarea
,Select
andSelectMenu
components:InputGroup
FormGroup
and now has its own documentation pageerror
prop has been added with its own presetui.formGroup.error
color
prop of children tored
label
,labelWrapper
andrequired
preset classes have been moved inlabel
objectInput
/Textarea
/Select
/SelectMenu
rounded
preset class has been moved from variants to the root of the preset to be customizable globallyplaceholder
preset class has been moved from variants to the root of the preset to be customizable globallyappearance
prop has been removed in favor ofcolor
(defaults towhite
) andvariant
(defaults tooutline
) to followBadge
andButton
convention, this will also allow us to define other variants in the futurepadded
prop has been added to remove padding easily