-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(forms): precise type assertion for onInput
event handler
#293
Conversation
@selemondev is attempting to deploy a commit to the Nuxt Labs Team on Vercel. A member of the Team first needs to authorize it. |
This might be worth replicating these changes in |
Done 🎉. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems your code formatter changed a lot of stuff in the Textarea
component.
What do you suggest I do? Should I return the default layout of the |
Yes you can revert these to only keep the type change I guess. |
Done 🎉. |
onInput
event handler
Thanks 😊 |
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
This commit updates the onInput event handler code. The type assertion in the code has been modified to cast event.target as HTMLInputElement instead of any. By using the specific HTMLInputElement type, we ensure accurate type checking and maintain type safety throughout the codebase. The event handler still emits the 'update:modelValue' event and updates the model value based on the input element's value. This modification enhances code clarity and provides more precise typing, leading to better code quality.