Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormGroup): add size prop and theme options #391

Merged
merged 8 commits into from
Jul 24, 2023

Conversation

henrycunh
Copy link
Contributor

what

  • Added a size property to the FormGroup component

why

To better fit with larger or smaller inputs!

image

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jul 20, 2023 8:24pm

@nuxt-studio
Copy link

nuxt-studio bot commented Jul 6, 2023

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview 7d593a4

@henrycunh
Copy link
Contributor Author

Note
Force-pushed a commit to remove pnpm-lock.yaml from it

@henrycunh
Copy link
Contributor Author

thanks for catching those @Haythamasalama!

Copy link
Member

Would it make sense to also pass the size prop down to the form element like the AvatarGroup and ButtonGroup?

@Haythamasalama
Copy link
Contributor

Would it make sense to also pass the size prop down to the form element like the AvatarGroup and ButtonGroup?

I realized that the FormGroup associated with one input doesn't seem to be important to pass. However, I don't think it's necessary to have a different size for the FormGroup and the input inside it every time. It would be easier for us to add a size parameter to the FormGroup instead of passing it to both every time.

@henrycunh
Copy link
Contributor Author

Thanks again @Haythamasalama! Made the controls for the props hidden on the documentation and passed down the size property to the input component.

@Haythamasalama
Copy link
Contributor

Thanks again @Haythamasalama! Made the controls for the props hidden on the documentation and passed down the size property to the input component.

You're welcome! It looks great! ✨👌

@benjamincanac benjamincanac changed the title feat(form-group): add size prop and theme options feat(FormGroup): add size prop and theme options Jul 20, 2023
@benjamincanac
Copy link
Member

I've made a few adjustments, let me know if this works for you!

@henrycunh
Copy link
Contributor Author

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants