feat(SelectMenu): handle async search #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mcastagnetti
changed the title
mcastagnetti
changed the title
benjamincanac
changed the title
|
Hello! Thanks for your PR! I've made a few adjustments so the function can be passed directly to the |
|
Thanks! The way you did is even simpler, I like it 🙂 |
benjamincanac
approved these changes
Jul 18, 2023
benjamincanac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #384
Add the possibility to set a
searchFunctionas prop to allow the user to have complete control of the way options are filtered.This function can be either synchronous or asynchronous.
Let me know what you think 🙂