Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Table): hide data when loading state is active #460

Merged
merged 4 commits into from
Jul 29, 2023
Merged

fix(Table): hide data when loading state is active #460

merged 4 commits into from
Jul 29, 2023

Conversation

Haythamasalama
Copy link
Contributor

After :
image

Before

image

@vercel
Copy link

vercel bot commented Jul 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jul 29, 2023 6:26pm

benjamincanac
benjamincanac reviewed Jul 29, 2023
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrapping the tr around a <template v-else> at the bottom would be better?

@Haythamasalama
Copy link
Contributor Author

Maybe wrapping the tr around a <template v-else> at the bottom would be better?

You are right

@Haythamasalama
Copy link
Contributor Author

@benjamincanac Done

@benjamincanac benjamincanac merged commit 2b3dc8d into nuxt:dev Jul 29, 2023
@Haythamasalama Haythamasalama deleted the fix(Table)-hide-data-when-loading branch July 29, 2023 22:13
@Tragio
Copy link
Contributor

Tragio commented Aug 3, 2023

@benjamincanac @Haythamasalama is there any way to have the older behavior? Because I have infinite scrolling and now I can't scroll, it jumps always to the top. Before it looked good because was showing that was loading more 🤔

@benjamincanac Volta.net
Copy link
Member

I guess you can disable the loadingState prop: :loading-state="null" and handle the loading yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac Awaiting requested review from benjamincanac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haythamasalama @Tragio @benjamincanac