Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nuxt 3 static rendering #84

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

Lexpeartha
Copy link
Contributor

Types of changes

  • New Detector
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added line that should recognize if current page has been prerendered on nuxt 3. However, I'm not quite sure if prerenderedAt returns value only per route, and if there is a more reliable way to actually detect if whole project has been prerendered.

Copy link
Member

atinux commented Sep 21, 2022

Would love to have an advice from @danielroe on this

@danielroe
Copy link
Contributor

danielroe commented Sep 21, 2022

This looks right to me, at the moment, but we may well need to update as we finish off the rest of nuxt/nuxt#14507.

cc: @pi0

@pi0
Copy link

pi0 commented Sep 22, 2022

Thanks for PR. LGTM too. prerenderedAt will be always in global NUXT. for pre-rendered pages (unless we renamed it for some reason in the future wich is unlikely).

@Lexpeartha
Copy link
Contributor Author

Interesting, so in that case maybe detector should prioritize static rendering(or vice versa), in cases where serverRendered is true, if only that route. Still not sure if "Rendering" sections should just display mode for current page (adding prerendering of the page in nitro config) or for the whole project (nuxt generate)
image

Copy link
Contributor

danielroe commented Sep 30, 2022

serverRendered means 'this is not a client-only page' (ie. similar semantics to ssr: true in nuxt config), rather than an alternative to static.

@atinux atinux merged commit 0fd1e22 into nuxtlabs:master Oct 5, 2022
Lexpeartha added a commit to Lexpeartha/vue-telescope-analyzer that referenced this pull request Dec 12, 2022
* fix: add `@nuxtjs/color-mode` recognition case (nuxtlabs#82)

* fix: use $img not $router for nuxt/image

Resolves nuxtlabs#83

* chore(release): 0.9.15

* feat: support nuxt 3 static rendering (nuxtlabs#84)

* feat: detect IP and localhost sites and remove mandatory https access (nuxtlabs#87)

* feat: add vitepress detection

* chore: update vitepress logo

* Update vitepress.svg

* feat: detect IP and localhost sites and remove mandatory https access

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>

* chore(release): 0.9.16

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: 吕振波 <32427677+lvzhenbo@users.noreply.github.com>
atinux added a commit that referenced this pull request Dec 19, 2022
* update to current main branch (#1)

* fix: add `@nuxtjs/color-mode` recognition case (#82)

* fix: use $img not $router for nuxt/image

Resolves #83

* chore(release): 0.9.15

* feat: support nuxt 3 static rendering (#84)

* feat: detect IP and localhost sites and remove mandatory https access (#87)

* feat: add vitepress detection

* chore: update vitepress logo

* Update vitepress.svg

* feat: detect IP and localhost sites and remove mandatory https access

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>

* chore(release): 0.9.16

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: 吕振波 <32427677+lvzhenbo@users.noreply.github.com>

* feat: add harlem detector

* docs: update README

* fix: use optional chaining

* Update README.md

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: 吕振波 <32427677+lvzhenbo@users.noreply.github.com>
Co-authored-by: Sébastien Chopin <seb@nuxtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants