From 5fe34c52a33000e7319e91bf3918f5a4c5bdbaef Mon Sep 17 00:00:00 2001 From: James Teh Date: Mon, 29 Oct 2018 14:13:08 +1000 Subject: [PATCH] Fix handling of table cells without a containing table in browse mode. (#8887) * Fix handling of table cells without a containing table in browse mode. In the new Gmail, message bodies are contained within a "gridcell" which does not have a containing grid. The gridcell's name is the entire body of the message. When using quick navigation to move to anything inside these "cells", NVDA reports information about the cell, including its name, after the element to which you just navigated. This results in a huge amount of spurious (and confusing) verbosity in Gmail when using quick navigation. To fix this, cells outside of tables are now treated as layout. * Update what's new. --- source/textInfos/__init__.py | 2 +- user_docs/en/changes.t2t | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/source/textInfos/__init__.py b/source/textInfos/__init__.py index a219a059d9..ebbebd41e5 100755 --- a/source/textInfos/__init__.py +++ b/source/textInfos/__init__.py @@ -59,7 +59,7 @@ def getPresentationCategory(self, ancestors, formatConfig, reason=controlTypes.R break else: table = None - if table and ((not formatConfig["includeLayoutTables"] and table.get("table-layout", None)) or table.get('isHidden',False)): + if not table or (not formatConfig["includeLayoutTables"] and table.get("table-layout", None)) or table.get('isHidden',False): return self.PRESCAT_LAYOUT if reason in (controlTypes.REASON_CARET, controlTypes.REASON_SAYALL, controlTypes.REASON_FOCUS) and ( (role == controlTypes.ROLE_LINK and not formatConfig["reportLinks"]) diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t index 0c8a8a461c..34f3583bc5 100644 --- a/user_docs/en/changes.t2t +++ b/user_docs/en/changes.t2t @@ -30,6 +30,7 @@ What's New in NVDA - NVDA no longer fails to track focus in File Explorer and other applications using UI Automation when another app is busy (such as batch processing audio). (#7345) - In ARIA menus on the web, the Escape key will now be passed through to the menu and no longer turn off focus mode unconditionally. (#3215) - NVDA no longer refuses to report the focus on web pages where the new focus replaces a control that no longer exists. (#6606, #8341) +- In the new Gmail, when using quick navigation inside messages while reading them, the entire body of the message is no longer reported after the element to which you just navigated. (#8887) - In BrowseMode, NVDA will now always report labels on divs and spans explicitly set by the web author. (#8886)