-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sound split: add an ability to adjust applications volume separately from NVDA volume #16444
Comments
If this feature is tied to sound split, I think it will limit its scope of use. Sound split is useful, but it does not mean that people use it all the time, and vice versa. |
@mltony to solve the decoupling issue, could you not use the internal mechanisms of audio ducking for designing this feature? There is no reflection in windows volume mixer needed. |
@cary-rowen I think still having it tied to sound split in the first step is good enough to have this in the core. When designing features it is always a trade-off. Either you insist on having the whole cake at once with the risk of not getting it at all, or people accept a piece of cake first and look where it goes afterwards. |
I think the operation for all applications should be part of Sound split. Why do you need to adjust the volume of all applications except NVDA without using this function? |
Is this not a duplicate of #16052? Generally we re-open the original issue after performing a revert |
Ok, I'll close this. It would be good to have an agreement on a path forward - I listed 5 requirements in #16440 - could you check that they make sense to you and I didn't leave anything out? |
Is your feature request related to a problem? Please describe.
With Sound split introduced in #16071, there appears to be no way to adjust volume of applications channel sepeartely from NVDA channel.
Describe the solution you'd like
Since #16273 is being reverted, I propose to reintroduce this in some form being exclusively marked as sound split feature to avoid any further confusion. We can rename it to something like: "Adjusting volume of applications channel in sound split mode". Thus it will be disabled when sound split is disabled. I also propose to get rid of applications mute feature as it seems to cause unnecessary confusion too.
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: