Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some changes from the linguist pull request? #256

Open
ice1000 opened this issue Aug 20, 2023 · 2 comments · May be fixed by #410
Open

Port some changes from the linguist pull request? #256

ice1000 opened this issue Aug 20, 2023 · 2 comments · May be fixed by #410

Comments

@ice1000
Copy link

ice1000 commented Aug 20, 2023

I saw michidk@4221511 from github-linguist/linguist#6379 which attempts to add Typst to GitHub linguist, and they author claimed that

So the original grammar from https://github.com/nvarner/typst-lsp had the following errors:
...
I now made a fork (https://github.com/michidk/typst-grammar) that has the required structure and fixes the issues.
The script runs and completes now without errors:

Maybe we can port that patch to this repo (should be very easy, just apply the diff)

@michidk
Copy link

michidk commented Aug 21, 2023

Keep in mind that my fork is probably very outdated by now. But I agree, it would be great if we could have an LSP definition compatible with GitHub's linguist. Then I could delete my repository and adjust my PR to use this one.

Btw the list of incompatibilities can be found here: github-linguist/linguist#6379 (comment)

@nvarner
Copy link
Owner

nvarner commented Aug 26, 2023

The TextMate grammar in this repo is unused and unmaintained. We switched to semantic token highlighting because it's based on the Typst parser, so we don't need to keep up with changes to the language's grammar. I'd be willing to patch in the changes, but I can't commit to keeping it up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants