Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub Actions for linting #134

Open
nvh95 opened this issue Jun 4, 2022 · 3 comments
Open

Setup GitHub Actions for linting #134

nvh95 opened this issue Jun 4, 2022 · 3 comments
Labels
enhancement Enhancement to current features/ behaviors good first issue Good for newcomers

Comments

@nvh95
Copy link
Owner

nvh95 commented Jun 4, 2022

Which feature you want to improve?
GitHub Actions CI

What and why you want to improve that feature
GitHub Actions CI should run linting. So contributors know they need to enforce the pretiier

Potential bugs/ unexpected behaviors
None for now

How to implement the changes

  • Update code inside .github/workflows.
  • If we can update in an existing .yml file, we do not need to run npm ci again
  • If npm run prettier fails, CI fails

Others
Do you have anything else you want to share about the improvement?

@nvh95 nvh95 added enhancement Enhancement to current features/ behaviors good first issue Good for newcomers labels Jun 4, 2022
@nvh95
Copy link
Owner Author

nvh95 commented Jun 4, 2022

Motivation for this issue: When reviewing code for #129

@tigerabrodi
Copy link

@nvh95 seems like a good story to begin with mhm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to current features/ behaviors good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants