Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection not working using link from LinkedIn App #99

Open
thibaut-hadjean opened this issue Jun 26, 2024 · 0 comments
Open

Redirection not working using link from LinkedIn App #99

thibaut-hadjean opened this issue Jun 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@thibaut-hadjean
Copy link

thibaut-hadjean commented Jun 26, 2024

Hello there 👋

I think there is an issue when we are using the library in a page directly loaded in the LinkedIn mobile application. Here is a video of what's happening: https://drive.google.com/file/d/1VF0qUVNjmLdpn-s_caOg1rqNL1s_AdzX/view?usp=sharing

From 0:00 to 0:26, I demonstrate that after logging in with LinkedIn, there is indeed a return to the platform https://unli.st, but nothing happens. Moreover, from 0:26 to 0:33, we see that it has disconnected me from the LinkedIn application (weird !).

Then I do exactly the same thing, but from one of my mobile browsers (here Google Chrome, but they all work). I go to the same address, take the same actions, and this time there is no problem. I successfully land on the page of my platform. This happens from 0:39 to 1:09.

I have also tested other InApp browsers on other applications, and there is never a problem. The only application that generates this issue is LinkedIn. I should mention that the platform (Unlist) is developed in React.js version 17, and the library used for executing the OAuth2 flow with LinkedIn is in version 2.0.1.

You can reproduce the issue by logging in with a LinkedIn account on the platform https://unli.st/sign-in from the mobile application (send yourself a the link in a private conversation and then open it in-app). The expected behavior is that we do not remain on a blank page, but rather are properly redirected to one of the platform's pages (the URL should then change, and not remain with the LinkedIn callback token). Any idea of what's happening ? (I thought about an issue with the LinkedIn app not opening in target=_blank as expected).

Thank you

EDIT: We needed to quick-fix this by disabling the button when we detect the LinkedIn InApp browser. But you can easily reproduce with whatever implementation you might already have by sending a link to your site sign-in flow in the LinkedIn app chat as I mentioned. I already contacted LinkedIn mobile app team about this issue, and they seem to point a problem on the library.

@thibaut-hadjean thibaut-hadjean added the bug Something isn't working label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant