fix: workspace summary ignore closed files and title field of metadata tag #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah you beat me to it by literally just a few minutes as I also sat down to fix this issue 😅 Thanks a lot for the fix! |
Oh, I'm sorry about making you a waste of time on this small problem. And I'm so proud of contributing this amazing project. |
|
You're all good don't worry about it. Thanks again :D |
benlubas
pushed a commit
to benlubas/neorg
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using
Neorg generate-workspace-summary. I met some problems similar with issue #1108 , and I solved them in this PRUncategorized: Files not opened cannot be categorized. Becauseget_document_metadatafunction use parser:children() function to getnorg_metaparser. But closed file's parser contains no children. So I directly usenorg_metaparser to parse the metadata, ifnorgparser found the metadata tag.title field ignored: while parsing metadata withbufnr, the first line, like@ducument.metawill confuse the treesitter. Then@document.meta \n title: <some title>while considered as a whole part. Then title be ignored.title like '02' be considered as number type: if title field is like '02', the title node's type will be number, then the value parsed would be "2".