-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow arguments for :Neorg generate-workspace-summary
#1156
Conversation
This method can be used to add custom metadata into file instead of defaults. If table is empty of nil then simply uses default like inject_metadata
No longer uses tabnew and relies on buffer 0 to insert metadata into the newly created file.
Added class annotations to better describe the input options for create_file and create_metadata.
spaces instead of tabs
Updated naming of @Class annotations to better align with the naming used in the rest of the project.
Dirman now broadcasts an event on file creation that metagen listen to. Metagen then injects desired metadata if present.
Neorg generate-workspace-summary now takes possible arguments. Each argument is space separated as a distinct category. Also made a method public to call it from lua instead of a vim command.
This looks good to me! Could you also add a small explanation to the comment at the top of the file explaining what the arguments to the |
Added documentation explaining how arguments work with the command `Neorg generate-workspace-summary`.
Sounds great. I've added a line or two explaining how to use arguments for the command. |
Not sure I understand why the build failed. I don't see any logs related to the summary module. :/ Do I need to revert my merge commit from |
Perfect, thank you for the PR! :) |
:Neorg generate-workspace-summary
Closes: #1086
Changes
This pull request changes the generate-workspace-summary in two ways:
Neorg generate-workspace-summary
command now takes optional arguments.generate_workspace_summary
such that it can be called through lua directly if needed.Needs feedback
The way it is implemented in this pull request accomplishes the goal by separating the arguments by space for separate categories, meaning you cannot target a category containing spaces with the neorgcmd.
I am not sure what is the better implementation - this or one where the Neorgcmd merges all inputs into a single category.