Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take two on the ToC changes #1500

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

benlubas
Copy link
Contributor

@benlubas benlubas commented Jul 5, 2024

I fixed the bug that I found in the last PR that still got merged despite the bug :P

Also in this PR:

  • fixed_width option for the ToC window
  • create_vsplit refactor/update to make use of the new nvim_open_win functionality in 0.10.0
  • Fixed logic for computing the ToC width
  • You can configure the toc command to just open but not enter the window

@benlubas
Copy link
Contributor Author

benlubas commented Jul 5, 2024

Question, should updating the ToC also update it's width? If I open a document with no headers, it will create an empty ToC that's not too wide, then I type a long heading, the ToC remains at it's earlier width, and is not updated.

I think it would be nice, but could get annoying depending on the other settings you have to see the window keep resizing

@vhyrro
Copy link
Member

vhyrro commented Jul 5, 2024

Perhaps it would be nice to have a minimum TOC width as well? I don't think it's too jarring to have the TOC resize personally.

@vhyrro vhyrro merged commit 83637f1 into nvim-neorg:main Jul 5, 2024
5 of 6 checks passed
@benlubas benlubas deleted the push-lrommpqqrtlp branch July 5, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants