Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operations): always force reinstalls if rocks are already installed #353

Merged
merged 1 commit into from
May 27, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented May 26, 2024

Fixes #351

Note: This doesn't actually work with luarocks 3.11.0, see luarocks/luarocks#1657

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

Copy link
Collaborator

@vhyrro vhyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for a new release of luarocks to drop, or are we merging this as-is?

@mrcjkb
Copy link
Member Author

mrcjkb commented May 27, 2024

Should we wait for a new release of luarocks to drop, or are we merging this as-is?

Let's merge. The flag doesn't do any harm in the buggy release, and #340 hasn't been merged yet, so most users are still building luarocks from master.

@mrcjkb mrcjkb merged commit 8537f6a into master May 27, 2024
12 checks passed
@mrcjkb mrcjkb deleted the force-reinstalls branch May 27, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Rocks update potentially not updating scm/dev plugins
2 participants