Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest commit (#922) breaks Telescope and many of my other plugins #945

Closed
mroavi opened this issue Jul 1, 2021 · 4 comments
Closed

Latest commit (#922) breaks Telescope and many of my other plugins #945

mroavi opened this issue Jul 1, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@mroavi
Copy link
Contributor

mroavi commented Jul 1, 2021

Description

After pulling the changes of the latest commit (feat: Consistent and sensible layout_config (#922)), many of my other plugins report the following error:

packer.nvim: Error running config for tmux-navigator: ...e/mroavi/.config/nvim/lua/mrv/plugins/tmux-navigator.lua:1: Vim:Deprecated window options. Please see ':help telescope.changelog'
packer.nvim: Error running config for delimitmate: /home/mroavi/.config/nvim/lua/mrv/plugins/delimitmate.lua:1: Vim:Deprecated window options. Please see ':help telescope.changelog'
packer.nvim: Error running config for vim-floaterm: /home/mroavi/.config/nvim/lua/mrv/plugins/floaterm.lua:1: Vim:Deprecated window options. Please see ':help telescope.changelog'

Telescope and the rest of my plugins were working fine before pulling the latest commit.

Expected Behavior
Telescope and all other plugins to work correctly.

Actual Behavior
Telescope does not work and neither do many of my other plugins. Removing Telescope gets rid of the messages in the other plugins.

Details

Run PackerSync
Close nvim and reopen it.

  • nvim --version: NVIM v0.5.0-dev+1459-g384f9870f

  • Operating system:
    NAME="Manjaro Linux"
    ID=manjaro
    ID_LIKE=arch
    BUILD_ID=rolling
    PRETTY_NAME="Manjaro Linux"
    ANSI_COLOR="32;1;24;144;200"
    HOME_URL="https://manjaro.org/"
    DOCUMENTATION_URL="https://wiki.manjaro.org/"
    SUPPORT_URL="https://manjaro.org/"
    BUG_REPORT_URL="https://bugs.manjaro.org/"
    LOGO=manjarolinux

  • nvim --version output:
    NVIM v0.5.0-dev+1459-g384f9870f
    Build type: RelWithDebInfo
    LuaJIT 2.1.0-beta3
    Compilation: /usr/bin/gcc-11 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/runner/work/neovim/neovim/build/config -I/home/runner/work/neovim/neovim/src -I/home/runner/work/neovim/neovim/.deps/usr/include -I/usr/include -I/home/runner/work/neovim/neovim/build/src/nvim/auto -I/home/runner/work/neovim/neovim/build/include
    Compiled by runner@fv-az139-878

    Features: +acl +iconv +tui
    See ":help feature-compile"

    system vimrc file: "$VIM/sysinit.vim"
    fall-back for $VIM: "/share/nvim"

  • Telescope commit: 5a53ec5 - (4 hours ago) feat: Consistent and sensible layout_config (feat: Consistent and sensible layout_config #922)

If you need more info, I would be more than happy to provide it to you guys.

@mroavi mroavi added the bug Something isn't working label Jul 1, 2021
@mroavi mroavi changed the title Latest commit breaks many of my other plugins Latest commit (#922) breaks many of my other plugins Jul 1, 2021
@mroavi mroavi changed the title Latest commit (#922) breaks many of my other plugins Latest commit (#922) breaks Telescope and many of my other plugins Jul 1, 2021
@clason
Copy link
Contributor

clason commented Jul 1, 2021

Did you read the mentioned document and adapted your own config to the breaking changes?

@mroavi
Copy link
Contributor Author

mroavi commented Jul 1, 2021

I did. I'm going to read it one more time.

@clason
Copy link
Contributor

clason commented Jul 1, 2021

Yes, this is (intentionally) a breaking change that requires (minor) adaptation of user config.

@mroavi
Copy link
Contributor Author

mroavi commented Jul 1, 2021

Commenting out prompt_position = "bottom" did the job. Thanks for your answer. Helped me pinpoint the problem with my config faster.

@mroavi mroavi closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants