Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with firstname options and buffer view #3176

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Wordluc
Copy link

@Wordluc Wordluc commented Jun 19, 2024

Fix issue: #3157 (comment)

@jamestrew
Copy link
Contributor

Hmm.. I think this is an issue that plagues various other places involving plenary's Path class and windows paths with mixed path separators.
This is probably best fixed upstream in plenary.

@Wordluc
Copy link
Author

Wordluc commented Jul 2, 2024

@jamestrew why the problem is plenary? the problem seems to be vim.fn.getbufinfo(bufnr)[1], that return the "wrong" result

@radlinskii
Copy link

This resolves the issue on my machine with Windows 11, together with path_display set to filename_first works very well

@jamestrew
Copy link
Contributor

This messes up unix paths.
We could do a workaround but my preference is to fix this in plenary.

why the problem is plenary? the problem seems to be vim.fn.getbufinfo(bufnr)[1], that return the "wrong" result

I say this because we use plenary for all the cross-platform path stuff and the path from getbufinfo eventually gets fed into plenary.Path. If we fix the issue in plenary, we can fix this + like 3 other nearly identical issues.

I'll try to work on this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants