$NVM_DIR/default-packages ignores last line

[waldyrious]

If the $NVM_DIR/default-packages file does not have a blank newline at the end, the contents of the last line are ignored.

• Operating system and version:
  macOS Mojave v10.14.2

• Output of nvm --version:
  0.33.11

• How did you install nvm?
  Homebrew

• What steps did you perform?

  1. Created $NVM_DIR/default-packages with the following contents:

     yarn
     npm
     typescript
     bunyan
     

  2. Ran nvm install stable

• What happened?
  Only first three packages in the $NVM_DIR/default-packages were installed

• What did you expect to happen?
  The last package listed in $NVM_DIR/default-packages (bunyan) should have been installed as well.

After I edited the $NVM_DIR/default-packages file to have a blank newline at the end, the same steps installed all four packages.

[ljharb]

While every file should always have a trailing newline, this certainly shouldn't fail. A PR to fix it, with a test, would be appreciated.

[ljharb]

hmm, actually i added a test but was unable to reproduce it. I'll reopen.

[waldyrious]

@ljharb sorry I wasn't able to reply earlier. Thank you for addressing this quickly :)