Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncaughtException catches exceptions from browser context #3061

Open
ghostoy opened this issue Feb 6, 2015 · 1 comment · May be fixed by nwjs/blink#17
Open

uncaughtException catches exceptions from browser context #3061

ghostoy opened this issue Feb 6, 2015 · 1 comment · May be fixed by nwjs/blink#17
Labels
bug dpd triaged

Comments

@ghostoy
Copy link
Member

ghostoy commented Feb 6, 2015

Test case:

<script>
process.on('uncaughtException', function(e) {
    console.log('caught!');
});
// following statement should throw a browser exception, but caught by `uncaughtException`
alert(NotDefinedVariable);
</script>

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@ghostoy ghostoy mentioned this issue Feb 6, 2015
Merged
@ghostoy ghostoy reopened this Feb 26, 2015
@ghostoy
Copy link
Member Author

ghostoy commented Mar 2, 2015

@rogerwang Is it possible to get it merged to master?

@ghostoy ghostoy linked a pull request Mar 25, 2015 that will close this issue
Open
@ghostoy ghostoy removed the test-todo label Jan 5, 2016
@RohitSharma27 RohitSharma27 mentioned this issue Feb 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug dpd triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix of uncaughtException should not catch browser exception ghostoy/blink
2 participants
@ghostoy @Christywl