Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwsaveas attribute regression #5667

Closed
conceptualspace opened this issue Jan 30, 2017 · 7 comments
Closed

nwsaveas attribute regression #5667

conceptualspace opened this issue Jan 30, 2017 · 7 comments

Comments

@conceptualspace
Copy link

conceptualspace commented Jan 30, 2017

nw: v0.20.0
os: win 10x64; osx 10.11.6
node: v6.8.0

it seems that there is a regression in v0.20.0 regarding the nwsaveas attribute.

it is working in nw0.17.6 but after upgrading to 0.20.0 the default filename is blank.

if it's helpful, the "accept" attribute still works (ie, the save file dialog shows my target extension, just not the file name)

@conceptualspace
Copy link
Author

on OSX, the filename is at least "Untitled"; on Windows it is an empty string

@conceptualspace
Copy link
Author

conceptualspace commented Feb 2, 2017

update:

issue only seems to occur if the node process is in development mode; in production mode everything works as expected

@rogerwang
Copy link
Member

what do you mean by "development mode" and "production mode"?

@conceptualspace
Copy link
Author

thought the behavior was being triggered by process.env.NODE_ENV being set to 'development', but it turns out that is not actually the case

@conceptualspace
Copy link
Author

(in other words, issue is still present in both cases, unfortunately)

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build. Thanks for reporting.

@rogerwang
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants