Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %chrome_ver or %chromium_ver to user-agent field in manifest #5975

Closed
sean220 opened this issue Jun 19, 2017 · 3 comments
Closed

Add %chrome_ver or %chromium_ver to user-agent field in manifest #5975

sean220 opened this issue Jun 19, 2017 · 3 comments

Comments

@sean220
Copy link

sean220 commented Jun 19, 2017

To custom use-agent with chrome/chromium version, Add the relevant variable would be helpful .

@sean220 sean220 changed the title Add %chrome_ver or % chromium_ver to user-agent field in manifest[future request] Add %chrome_ver or %chromium_ver to user-agent field in manifest[future request] Jun 19, 2017
@sean220 sean220 changed the title Add %chrome_ver or %chromium_ver to user-agent field in manifest[future request] Add %chrome_ver or %chromium_ver to user-agent field in manifest Jun 20, 2017
@AshleyScirra
Copy link

This would be useful for us with Construct 2/Construct 3. Some of our code, and some of the libraries we depend on, do user-agent sniffing to determine what's supported. If Chrome/XX is not present in the user agent then these checks fail and then code that worked in Chrome no longer works in NW.js. This can be worked around by manually adding "(like Chrome/63 )" to the UA, but it would be nice if this auto-updated.

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@AshleyScirra
Copy link

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants