-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting --user-data-dir to custom location still causes AppData folder to be created #6328
Comments
I can reproduce this issue on Linux/Windows with nwjs-sdk-v0.27.1. |
Is this bug fixed yet? nw.js version 0.31.4 still has this problem, that's annoying. |
I would like to add a [Feature Request] to simply not write the app_name (where app_name is the name field value in the package.json) not only from the \Local\AppData location, but do not write it anywhere if possible. Here is a thread on the Google Group explaining more details with Roger: |
I'm having the same issue. The environment variables aren't being expanded, but are being used as literals. nwjs:0.32.4 |
@rogerwang is there a plan to fix this? Or at least offer an nwjs api/setting to use %APPDATA% rather than %LOCALAPPDATA% which is the default now. This bug makes it impossible to have the user-data-dir in each users roaming folder. |
Version: {
"name": "test",
"version": "0.0.1",
"main": "app.js"
"chromium-args": [
"--user-data-dir=./data"
]
} Does not work for me. |
@rogerwang here is a pull request that fixes this issue. #7477 . At Mitel we use nwjs for our UC client and need to have local storage in the roaming folder (%APPDATA%) rather than %LOCALAPPDATA%. Please have a look. |
Has this issue been fixed? From the PR it looks like it's all done. |
I just tested this out and it's still broken. My steps to reproduce (sample: package.zip):
|
@TheRealDannyyy yes its working really well ;). Be careful to use single quotes to handle paths with spaces. Here is an example with single quotes in two places. "chromium-args": "--user-data-dir='%APPDATA%'\TheProduct\'User Data'" |
@mkilburn60 Based on my test case it doesn't. It seems like crashpad is causing a userdir to be created inside the appdata folder. |
@TheRealDannyyy note you two backslash for each of the path separators but this page removes one when it renders. |
@TheRealDannyyy thats true - crash dumps still go to the default. |
@TheRealDannyyy I'm guessing the same fix would need to be applied to --crash-dumps-dir |
@TheRealDannyyy the expansion is applied to the whole command line so try setting --crash-dumps-dir to %APPDATA% |
Hi guys, is the problem still not solved? |
NWJS Version : 0.27.1
Operating System : Windows 10
Expected behavior
If user-data-dir is set to a custom location, no folder should be created in AppData\Local%appname%
Actual behavior
Empty folders are created in AppData\Local%appname%. Specifically a User Data and a User Data\CrashPad folder are created
How to reproduce
The text was updated successfully, but these errors were encountered: