Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply accessing chrome.action (get) crashes nw28-rc1 #6372

Closed
SMotaal opened this issue Jan 6, 2018 · 1 comment
Closed

Simply accessing chrome.action (get) crashes nw28-rc1 #6372

SMotaal opened this issue Jan 6, 2018 · 1 comment

Comments

@SMotaal
Copy link

SMotaal commented Jan 6, 2018

Environment

NWJS Version :

 http_parser: 2.7.0,
 node: 9.3.0,
 v8: 6.4.388.12,
 uv: 1.18.0,
 zlib: 1.2.11,
 ares: 1.13.0,
 modules: 59,
 nghttp2: 1.25.0,
 openssl: 1.0.2n,
 icu: 60.1,
 unicode: 10.0,
 cldr: 32.0,
 tz: 2017c,
 nw: 0.28.0-rc1,
 node-webkit: 0.28.0-rc1,
 nw-commit-id: 9c2248c-b158474-caf1f0d-1b41f4f,
 chromium: 64.0.3282.71

Operating System :

 macOS: 10.13.2 (17C88)

Expected behavior

The first time during the life span of a background page when chrome.action is accessed, it will trigger chrome's defined getter (lazy load/bind the relevant API aspects), and should return an object with various API methods or properties.

Actual behavior

NWJS craches abruptly:

[3560:775:0106/065420.764817:FATAL:v8_schema_registry.cc(135)] Check failed: !schema_string.empty(). 
0   nwjs Framework                      0x00000001041f261c v8_inspector::V8StackTraceId::IsInvalid() const + 5611836
1   nwjs Framework                      0x000000010420a862 v8_inspector::V8StackTraceId::IsInvalid() const + 5710722
2   nwjs Framework                      0x0000000103de460a v8_inspector::V8StackTraceId::IsInvalid() const + 1360170
3   nwjs Framework                      0x0000000103de4943 v8_inspector::V8StackTraceId::IsInvalid() const + 1360995
4   nwjs Framework                      0x0000000103dcce8d v8_inspector::V8StackTraceId::IsInvalid() const + 1264045
5   nwjs Framework                      0x0000000103482f01 v8::internal::VirtualMemory::TakeControl(v8::internal::VirtualMemory*) + 801
6   nwjs Framework                      0x00000001035183ab v8::internal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, v8::internal::BasicBlockProfiler const&) + 140731
7   nwjs Framework                      0x0000000103517a3c v8::internal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, v8::internal::BasicBlockProfiler const&) + 138316
8   ???                                 0x0000044c4f1047dd 0x0 + 4725790492637
9   ???                                 0x0000044c4f112ee8 0x0 + 4725790551784
10  ???                                 0x0000044c4f1107f8 0x0 + 4725790541816
11  ???                                 0x0000044c4f10ac9f 0x0 + 4725790518431
12  nwjs Framework                      0x00000001037f225c v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 892
13  nwjs Framework                      0x00000001037f1f72 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 146
14  nwjs Framework                      0x00000001034a770f v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 655
15  nwjs Framework                      0x0000000103d807ab v8_inspector::V8StackTraceId::IsInvalid() const + 950987
16  nwjs Framework                      0x0000000103dc7653 v8_inspector::V8StackTraceId::IsInvalid() const + 1241459
17  nwjs Framework                      0x00000001038cfea4 v8::internal::StoreBuffer::StoreBufferOverflow(v8::internal::Isolate*) + 94644
18  nwjs Framework                      0x0000000103954b65 v8::internal::Object::GetProperty(v8::internal::LookupIterator*) + 2501
19  nwjs Framework                      0x00000001038c27b5 v8::internal::StoreBuffer::StoreBufferOverflow(v8::internal::Isolate*) + 39621
20  nwjs Framework                      0x00000001038c9370 v8::internal::StoreBuffer::StoreBufferOverflow(v8::internal::Isolate*) + 67200
21  ???                                 0x0000044c4f1047dd 0x0 + 4725790492637

How to reproduce

Accessing chrome.action by calling it within a script or by inspecting the background page's chrome then clicking through to try to look inside action.

This was initially encountered on an earlier nw28 beta (but they were custom built) however when the problem persisted on your recent nightly build (used without any alterations as downloaded from your server) I determined that the issue must be upstreamed (might even be chromium related — but I doubt I can verify this on my end).

@rogerwang
Copy link
Member

The API is still under development in upstream and should not be exposed. Fixed in git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants