Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.63.0+: global is not set on windows opened with new_instance true #7866

Closed
sdurham opened this issue Apr 21, 2022 · 3 comments
Closed

0.63.0+: global is not set on windows opened with new_instance true #7866

sdurham opened this issue Apr 21, 2022 · 3 comments

Comments

@sdurham
Copy link

sdurham commented Apr 21, 2022

NWJS Version : 0.63.1
Operating System : Mac Monterey 12.2.1 (non m1 mac). I have not tried windows.

Expected behavior

nw.global is populated after nw.Window.open(..., { new_instance: true });

Actual behavior

nw.global appears to be empty {}, and attempting to access anything (set or get) give a "no access" error.

How to reproduce

Easy -- just do nw.window.open(, { new_instance: true }) from the main app.
Then in the new window, take a look at global in the console.
This is working fine in 0.62.1

@TheJaredWilcurt
Copy link
Member

TheJaredWilcurt commented Apr 21, 2022

@rogerwang Was able to reproduce:

Tested in Windows 10 64-bit.

Issue is present in:

  • 0.63.0, 0.63.1 (latest)

Issue not present in:

  • 0.62.2

Diff:

Reproduction link:

@TheJaredWilcurt TheJaredWilcurt changed the title 0.63.1: global is not set on windows opened with new_instance true 0.63.0+: global is not set on windows opened with new_instance true Apr 24, 2022
@sdurham
Copy link
Author

sdurham commented May 27, 2022

Hi, hopefully this is a small fix? Can we get it in soon?

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants