-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Empty formatter, no formatter #180
Config: Empty formatter, no formatter #180
Conversation
The default formatter should be |
Sounds good to me. @nwolverson What do you think? |
Yep I agree, interpret anything other than the specific formatter strings as |
Every other value is interpreted as `NoFormatter`
@@ -198,12 +198,10 @@ formatter :: ConfigFn Formatter | |||
formatter = | |||
getString "formatter" "" | |||
>>> case _ of | |||
"none" -> NoFormatter | |||
"" -> NoFormatter | |||
"purty" -> Purty | |||
"purs-tidy" -> PursTidy |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You tell me. Is tidy
the more common name?
The npm package, the cli command and the announcement all use purs-tidy
.
My preferred way would be to allow both tidy
and purs-tidy
since it's easy to mixup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm aware that's its name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(interestingly both wclr and nwolverson you referred to it as tidy in your above comments :D)
Is the PR content in it's recent state okay? |
@@ -200,6 +200,7 @@ formatter = | |||
>>> case _ of | |||
"purty" -> Purty | |||
"purs-tidy" -> PursTidy | |||
"tidy" -> PursTidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Oops, wrong button 😅 |
Hey,
Before looking it up, my first try to disable an existing formatter was to set the field to
""
. Later I found out there is"none"
.I would also interpret
""
asNoFormatter
, but it's up to you if you think that's a good idea or not :)