Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): validate options.app.* values #1302

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Nov 16, 2024

Fixes: #1279
Fixes: #1293

Copy link
Contributor

github-actions bot commented Nov 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 32.14% 613 / 1907
🔵 Statements 32.14% 613 / 1907
🔵 Functions 41.93% 13 / 31
🔵 Branches 68% 51 / 75
File CoverageNo changed files found.
Generated in workflow #1006 for commit 6034618 by the Vitest Coverage Report Action

@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review November 20, 2024 12:35
@ayushmanchhabra ayushmanchhabra merged commit 4f388a9 into main Nov 20, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the fix/options-app-val branch November 20, 2024 12:35
ayushmanchhabra pushed a commit that referenced this pull request Nov 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.12.0](v4.11.6...v4.12.0)
(2024-11-21)


### Features

* **run:** return NW.js process reference
([#1304](#1304))
([bd2f926](bd2f926))


### Bug Fixes

* miscellaneous quality of life improvements
([#1296](#1296))
([a82c140](a82c140))
* **util:** validate options.* correctly
([#1298](#1298))
([3034f5c](3034f5c))
* **util:** validate options.app.* values
([#1302](#1302))
([4f388a9](4f388a9)),
closes [#1279](#1279)
[#1293](#1293)


### Chores

* **deps-dev:** bump the npm group across 1 directory with 6 updates
([#1301](#1301))
([56c1192](56c1192))
* **deps:** bump cross-spawn from 7.0.3 to 7.0.6
([#1305](#1305))
([2803af3](2803af3))
* **deps:** bump davelosert/vitest-coverage-report-action from 2.6.0 to
2.7.0 in /.github/workflows in the gha group
([#1295](#1295))
([23aaad8](23aaad8))
* **deps:** bump davelosert/vitest-coverage-report-action from 2.7.0 to
2.8.0 in /.github/workflows in the gha group
([#1303](#1303))
([ceaf348](ceaf348))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant't build NW application, an error was thrown. App icon missing/blank in MacOS ARM64 build
1 participant