Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows package with zip:false will not update #111

Open
neels opened this issue Sep 13, 2016 · 3 comments
Open

Windows package with zip:false will not update #111

neels opened this issue Sep 13, 2016 · 3 comments

Comments

@neels
Copy link
Contributor

neels commented Sep 13, 2016

Hello All

If I package a windows app with node-webkit-builder as zip:false (all files and package.json in exe directory not as nw.pak) the app starts downloading package and unzips runs in temp but never replaces the old app.

I had to do this to get a faster windows app startup.

It works if I have the normal nw.pak structure on Windows.

Can someone please guide me in the right direction?

@neels
Copy link
Contributor Author

neels commented Sep 13, 2016

Works for me now.

If anyone runs into the same issue as me just update....

app/updater.js:
line 394: del(to, {force: true}, cb); -----> del(to + '/**/*', {force: true}, cb);

and when you call run:
upd.run(execPath, []); //do not use "null" in second parameter as that crashes the app

Hope this helps someone else.

@adam-lynch
Copy link
Collaborator

@neels I guess we should add an option for this. I don't know what that option would be named though.

Would you like to submit a pull-request to add this?

@neels
Copy link
Contributor Author

neels commented Oct 17, 2016

@adam-lynch I have created a pull request. #113

Thanks for this awesome updater!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants