Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If status bar un-hidden by subclassed NYTPhotosViewController variant (in order to avoid distorting other view controllers by hiding status bar during animation to/from modal), NYTPhotosOverlayView underlaps system status bar. #266

Open
benguild opened this issue May 1, 2018 · 0 comments

Comments

@benguild
Copy link

benguild commented May 1, 2018

This has been addressed by #221 and somewhat repaired by the comments and changes that I suggested on that PR, but I just wanted to bring it up.

Since NYTPhotosOverlayView isn't a view controller or navigation controller, it doesn't get the status bar indent "for free" as other views would.

However, by hiding the status bar on this modal entirely, it can negatively affect other views underneath.

It seems quite natural to me to have an option to retain the status bar as it looks fine when set to "light content" mode, although debatably visually distracting.

@benguild benguild changed the title If status bar not hidden by subclassed NYTPhotosViewController variant (in order to avoid distorting other view controllers by hiding status bar during animation to/from modal), NYTPhotosOverlayView underlaps system status bar. If status bar un-hidden by subclassed NYTPhotosViewController variant (in order to avoid distorting other view controllers by hiding status bar during animation to/from modal), NYTPhotosOverlayView underlaps system status bar. May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant